Skip to content

[Mercure] Update token generation #14670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Dec 11, 2020
Merged

[Mercure] Update token generation #14670

merged 1 commit into from Dec 11, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 7, 2020

Following the release of the version 4 of the lcobucci/jwt library, we get the following error Cannot Instantiate Interface Lcobucci\JWT\Builder, same thing with Key.

Like you can see here : https://github.com/lcobucci/jwt/releases/tag/4.0.0, there are BC-break about Key and Builder who have become Interface.

In accordance with the documentation on https://lcobucci-jwt.readthedocs.io/en/latest/configuration/#configuration, I allow myself to propose the following merge request.

@javiereguiluz
Copy link
Member

Florent, thanks for improving this doc and for the nice explanation. Congrats on your first Symfony Docs contribution!

@javiereguiluz javiereguiluz merged commit 65d45be into symfony:5.2 Dec 11, 2020
OskarStark added a commit that referenced this pull request Dec 18, 2020
This PR was merged into the 4.4 branch.

Discussion
----------

[Mercure] Support JWT v4

This is the same change as #14670 but it should have been merged into branch 4.4 and merged up.

Commits
-------

1e1ff71 Support JWT v4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants