[Form] Add choice_translation_parameters option #14699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
requested changes
Dec 14, 2020
|
Friendly ping @OskarStark is it now ok for you ? |
OskarStark
approved these changes
Jan 3, 2021
xabbuh
reviewed
Jan 3, 2021
reference/forms/types/options/choice_translation_parameters.rst.inc
Outdated
Show resolved
Hide resolved
reference/forms/types/options/choice_translation_parameters.rst.inc
Outdated
Show resolved
Hide resolved
|
@VincentLanglet could you please apply the comments made by @xabbuh ? Thanks! |
ac1809c to
f169f55
Compare
It should be ok now ; but I got an unrelated error @OskarStark |
OskarStark
approved these changes
Jan 10, 2021
|
@VincentLanglet Can you rebase here please? |
|
Sure, it's done @xabbuh |
xabbuh
approved these changes
Jan 10, 2021
|
Thank you Vincent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #13677
The feature is merged symfony/symfony#38469