[Cache] Add TLS scheme for Redis connection #14728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Dec 22, 2020
maxhelias
approved these changes
Jan 8, 2021
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Feb 22, 2021
… (misaert) This PR was submitted for the 5.x branch but it was merged into the 4.4 branch instead. Discussion ---------- [Cache] Fix Redis TLS scheme `rediss` for Redis connection | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#14728 Like #35503 on Symfony Messenger, this will enable TLS support for Redis adapter. The implementation just prefix the host with `tls://` as described here: https://github.com/phpredis/phpredis#connect-open I don't know how to test it because I guess I need a TLS Redis in `src/Symfony/Component/Cache/Tests/Adapter/RedisAdapterTest.php`. Commits ------- 3288897 [Cache] Fix Redis TLS scheme `rediss` for Redis connection
|
Is that correct? Isn't TLS enabled by using the |
|
No, it is not correct because the implementation has changed over time. I take care of changing this PR to correspond with the choosen implementation 😉 |
|
Changed. Do I have to change the destination of the branch to |
|
Yes please, and rebase on 4.4 before. |
|
Done. |
OskarStark
reviewed
Feb 22, 2021
OskarStark
approved these changes
Feb 22, 2021
maxhelias
approved these changes
Feb 23, 2021
nicolas-grekas
approved these changes
Feb 23, 2021
wouterj
added a commit
that referenced
this pull request
Apr 7, 2021
|
Hi @misaert! I'm not sure why this PR has been open for quite a while after the code merge. All seems perfect. Thanks for taking care of updating the docs! |
wouterj
added a commit
that referenced
this pull request
Apr 8, 2021
* 4.4: Add troubleshooting for parallel merges to maintainer guide Update framework.rst JsonResponse content updated [#14728] Be explicit about the double 's' [Messenger] fix typo [Messenger] Routing & Inheritance [Cache] Add TLS scheme for Redis connection
wouterj
added a commit
that referenced
this pull request
Apr 8, 2021
* 5.2: Add troubleshooting for parallel merges to maintainer guide Update framework.rst JsonResponse content updated Fixed table markup [Messenger] Add options for PostgreSQL LISTEN/NOTIFY support Update data_collector.rst [#14728] Be explicit about the double 's' [#14700] Minor rewording Update login_link.rst Added explaination on context in events and initial marking [Messenger] fix typo [Messenger] Routing & Inheritance docs(http-client): fix default retry_failed configuration example [Cache] Add TLS scheme for Redis connection
This was referenced Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See symfony/symfony#39599.