[RateLimiter] Adding config reference for policy and lock_factory #14746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56428f4 to
8179bed
Compare
Nyholm
commented
Dec 27, 2020
| """""""""""" | ||
|
|
||
| The service that is used to create a lock. The service has to implement the | ||
| :class:`Symfony\\Component\\Lock\\LockFactoryInterface`. |
There was a problem hiding this comment.
In 5.2 it should be LockFactory
But (hopefully) this is correct in 5.3: symfony/symfony#39634
There was a problem hiding this comment.
We did this change while merging. Cheers!
7922194 to
c39447a
Compare
|
Thanks for yet another contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding some config reference that are missing