Skip to content

[Form] Shortening the text and adding link to jQuery #14760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

ThomasLandauer
Copy link
Contributor

As a separate PR, as recommended by #13450 (comment)

@carsonbot carsonbot added this to the 4.4 milestone Dec 30, 2020
@javiereguiluz javiereguiluz merged commit 734c8b1 into symfony:4.4 Dec 30, 2020
@carsonbot carsonbot changed the title Shortening the text and adding link to jQuery [Form] Shortening the text and adding link to jQuery Dec 30, 2020
@javiereguiluz
Copy link
Member

Thomas, thanks for this contribution. However, we had to revert most of the changes for some reasons:

  • In Symfony Docs we don't use the "we" form ... so this text can't be included -> "Now we need some [...]"
  • I didn't agree with the removal of the last phrase because it's important to note that we're using jQuery but we're not including it, so you must do something not explained here to be sure that jQuery is available.

We kept the button -> link fix and the new jQuery link is nice too. Thanks to your contribution, we realized that we need to give some clue about how to include jQuery in case the reader is lost. So, the new paragraph contents are as follows:

The goal of this section will be to use JavaScript to read this attribute
and dynamically add new tag forms when the user clicks the "Add a tag" link.
This example uses `jQuery`_ and assumes you have it included somewhere on your
page (e.g. using Symfony's :doc:`Webpack Encore </frontend>`).

Thanks as always for understanding 🙏

@ThomasLandauer ThomasLandauer deleted the patch-8 branch December 30, 2020 15:56
ThomasLandauer added a commit to ThomasLandauer/symfony-docs that referenced this pull request Dec 30, 2020
Follow up of symfony#14760
"The goal of this section will be" is horrible IMHO ;-)
javiereguiluz added a commit that referenced this pull request Dec 30, 2020
This PR was merged into the 4.4 branch.

Discussion
----------

[Form] Minor rewording

Follow up of #14760
"The goal of this section will be" is horrible IMHO ;-)

Commits
-------

46322c9 Minor rewording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants