Skip to content

[Form] Shortening the text some more #14761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Conversation

ThomasLandauer
Copy link
Contributor

As a separate PR, as recommended by #13450 (comment)

  • Reason for deleting "Add a script tag somewhere on your page...": Lenghthy text that didn't say much ;-)
  • Reason for deleting the note: The JavaScript code is shown in itself; not inside some HTML ;-)

As a separate PR, as recommended by symfony#13450 (comment)

* Reason for deleting "Add a script tag somewhere on your page...": Lenghthy text that didn't say much ;-)
* Reason for deleting the `note`: The JavaScript code is shown in itself; not inside some HTML ;-)
*
@carsonbot carsonbot added this to the 4.4 milestone Dec 30, 2020
@javiereguiluz javiereguiluz merged commit aa075e9 into symfony:4.4 Dec 30, 2020
@carsonbot carsonbot changed the title Shortening the text some more [Form] Shortening the text some more Dec 30, 2020
@javiereguiluz
Copy link
Member

Thanks Thomas. While merging we did this minor change in your contribution:

-Now add the required functionality with JavaScript:
+Add a ``<script>`` tag somewhere on your page to include the required
+functionality with JavaScript:

I know that adding the <script> tag may sound obvious ... but some readers will need it ... and we also say "anywhere on your page", to ensure them that it doesn't matter where they add it. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants