Skip to content

[Form] Rewording #14762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2020
Merged

[Form] Rewording #14762

merged 1 commit into from
Dec 30, 2020

Conversation

ThomasLandauer
Copy link
Contributor

As a separate PR, as recommended by #13450 (comment)

Note: addTagForm was the wrong function name, it's now called addFormToCollection()

As a separate PR, as recommended by symfony#13450 (comment)

Note: `addTagForm` was the wrong function name, it's now called `addFormToCollection()`
@carsonbot carsonbot added this to the 4.4 milestone Dec 30, 2020
@carsonbot carsonbot changed the title Rewording [Form] Rewording Dec 30, 2020
@javiereguiluz javiereguiluz merged commit 0e1fc2f into symfony:4.4 Dec 30, 2020
@javiereguiluz
Copy link
Member

Thomas, we agree on removing this phrase because it doesn't say much -> "The actual code needed to make this all work can vary quite a bit, but here's one example:"

However, we disagree with the removal of the first phrase: "The addFormToCollection() function's job will be to use the data-prototype attribute to dynamically add a new form when this link is clicked.". That's the most crucial phrase to understand what's that "strange" data-prototype attribute, so we left it. However, we included your minor tweaks to the original text.

Thanks!

@ThomasLandauer ThomasLandauer deleted the patch-13 branch December 30, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants