Skip to content

[Mailer] Add missing transports entry in XML and PHP configurations #14826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

sebpacz
Copy link
Contributor

@sebpacz sebpacz commented Jan 12, 2021

The YAML configuration of the Messenger component contains the transports entry that is not defined in the XML and PHP configurations.

@carsonbot
Copy link
Collaborator

Hey!

I like what you have done here.

I think @Calinou has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@Calinou
Copy link
Contributor

Calinou commented Jan 13, 2021

@carsonbot I haven't 👀

@javiereguiluz
Copy link
Member

Sebastian, thanks for completing the missing config formats.

@javiereguiluz javiereguiluz merged commit 84ecdbf into symfony:4.4 Jan 18, 2021
@sebpacz sebpacz deleted the mailer branch January 19, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants