Clarify how to write a commit message and CHANGELOGs #14830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e377dbf to
5d220f0
Compare
OskarStark
reviewed
Jan 14, 2021
OskarStark
reviewed
Jan 14, 2021
OskarStark
reviewed
Jan 14, 2021
5d220f0 to
d15db49
Compare
d15db49 to
8ecd162
Compare
|
@Nyholm do you think this can be achieved by fabbot? Otherwise I am afraid, we cannot think of it all the time |
|
I'm the one managing fabbot :) |
Indeed, he is actively working on gh and carsonbot 😃 |
OskarStark
approved these changes
Jan 14, 2021
Nyholm
approved these changes
Jan 14, 2021
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jan 14, 2021
This PR was merged into the 5.3-dev branch. Discussion ---------- No patch version in CHANGELOG | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- Based on symfony/symfony-docs#14830 cc @fabpot, feel free to close, as we discussed this already via Slack Commits ------- 575d9b0 No patch version in CHANGELOG
|
Regarding commit messages, are you aware of the conventional commits spec? It has a nice syntax and some tools already implement it (GitHub bots checking message formats, changelog generators, linters, IDE plugins etc). For Symfony commit messages following this spec would look like: |
|
TBH, that's looks really ugly :) And we already have tools built around our conventions. |
xabbuh
approved these changes
Jan 14, 2021
symfony-splitter
pushed a commit
to symfony/notifier
that referenced
this pull request
Jan 14, 2021
This PR was merged into the 5.3-dev branch. Discussion ---------- No patch version in CHANGELOG | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- Based on symfony/symfony-docs#14830 cc @fabpot, feel free to close, as we discussed this already via Slack Commits ------- 575d9b04b4 No patch version in CHANGELOG
symfony-splitter
pushed a commit
to symfony/mattermost-notifier
that referenced
this pull request
Jan 15, 2021
This PR was merged into the 5.3-dev branch. Discussion ---------- No patch version in CHANGELOG | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- Based on symfony/symfony-docs#14830 cc @fabpot, feel free to close, as we discussed this already via Slack Commits ------- 575d9b04b4 No patch version in CHANGELOG
symfony-splitter
pushed a commit
to symfony/slack-notifier
that referenced
this pull request
Jan 15, 2021
This PR was merged into the 5.3-dev branch. Discussion ---------- No patch version in CHANGELOG | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- Based on symfony/symfony-docs#14830 cc @fabpot, feel free to close, as we discussed this already via Slack Commits ------- 575d9b04b4 No patch version in CHANGELOG
symfony-splitter
pushed a commit
to symfony/linked-in-notifier
that referenced
this pull request
Jan 15, 2021
This PR was merged into the 5.3-dev branch. Discussion ---------- No patch version in CHANGELOG | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- Based on symfony/symfony-docs#14830 cc @fabpot, feel free to close, as we discussed this already via Slack Commits ------- 575d9b04b4 No patch version in CHANGELOG
symfony-splitter
pushed a commit
to symfony/esendex-notifier
that referenced
this pull request
Jan 15, 2021
This PR was merged into the 5.3-dev branch. Discussion ---------- No patch version in CHANGELOG | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- Based on symfony/symfony-docs#14830 cc @fabpot, feel free to close, as we discussed this already via Slack Commits ------- 575d9b04b4 No patch version in CHANGELOG
symfony-splitter
pushed a commit
to symfony/zulip-notifier
that referenced
this pull request
Jan 15, 2021
This PR was merged into the 5.3-dev branch. Discussion ---------- No patch version in CHANGELOG | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- Based on symfony/symfony-docs#14830 cc @fabpot, feel free to close, as we discussed this already via Slack Commits ------- 575d9b04b4 No patch version in CHANGELOG
|
Thank you Fabien. |
This was referenced Jan 18, 2021
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Feb 5, 2021
This PR was submitted for the 5.x branch but it was merged into the 4.4 branch instead. Discussion ---------- Update PULL_REQUEST_TEMPLATE.md | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | See #40097 (comment) | License | MIT | Doc PR | Doc introduced in symfony/symfony-docs#14830 ping @OskarStark do you think this can be valuable here? as this file is the entry point of all PRs Commits ------- 41c7796 Update PULL_REQUEST_TEMPLATE.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.