Skip to content

[Notifier] Add symfony/gitter-notifier docs #14835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2021
Merged

[Notifier] Add symfony/gitter-notifier docs #14835

merged 1 commit into from
Jan 21, 2021

Conversation

christingruber
Copy link
Contributor

This was referenced Jan 15, 2021
Merged
Merged
@javiereguiluz javiereguiluz added Notifier Waiting Code Merge Docs for features pending to be merged labels Jan 15, 2021
@carsonbot carsonbot changed the title Add symfony/gitter-notifier docs [Notifier] Add symfony/gitter-notifier docs Jan 15, 2021
@carsonbot carsonbot added this to the next milestone Jan 15, 2021
OskarStark
OskarStark approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After my comment 👍🏻

@OskarStark
Copy link
Contributor

Can you please rebase? Thanks

@OskarStark OskarStark removed the Waiting Code Merge Docs for features pending to be merged label Jan 20, 2021
OskarStark added a commit to symfony/symfony that referenced this pull request Jan 20, 2021
@OskarStark
feature #39838 [Notifier] Add Gitter Bridge (christingruber)
4818b28 
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Notifier] Add Gitter Bridge

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| License       | MIT
| Doc PR        | symfony/symfony-docs#14835

Adds a notifier bridge for https://gitter.im the API documentation https://developer.gitter.im/docs/rest-api.

Commits
-------

d033677 Add symfony/gitter-notifier bridge
@christingruber christingruber force-pushed the feature/gitter-notifier branch from 53e6528 to b66c696 Compare January 20, 2021 16:21
@christingruber christingruber force-pushed the feature/gitter-notifier branch from b66c696 to 26e88f7 Compare January 20, 2021 16:26
@christingruber
Copy link
Contributor Author

Rebased 👍

@xabbuh xabbuh modified the milestones: next, 5.3 Jan 21, 2021
@OskarStark
Copy link
Contributor

Thanks Christin for working on this feature, this is much appreciated.

@OskarStark OskarStark merged commit 1970e1d into symfony:5.x Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Notifier Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
5 participants
@christingruber @OskarStark @xabbuh @javiereguiluz @carsonbot