Skip to content

[Logger] Just moving this note upwards #14858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

ThomasLandauer
Copy link
Contributor

Reasons:

  • It's a general thing, has nothing to do with "Handlers that Modify Log Entries".
  • Since this behavior is uncommon in Symfony, it should be explained as early as possible.
  • Fits quite well after this sentence:

    This defines a stack of handlers and each handler is called in the order that it’s defined.

Reasons:
* It's a *general* thing, has nothing to do with "Handlers that Modify Log Entries".
* Since this is uncommon in Symfony, it should be explained as early as possible.
* Fits quite well after this sentence:
  > This defines a stack of handlers and each handler is called in the order that it’s defined.
@carsonbot carsonbot added this to the 4.4 milestone Jan 19, 2021
@carsonbot carsonbot changed the title Just moving this note upwards [Logger] Just moving this note upwards Jan 20, 2021
@javiereguiluz
Copy link
Member

Thanks Thomas.

@javiereguiluz javiereguiluz merged commit ed121ec into symfony:4.4 Jan 20, 2021
@ThomasLandauer ThomasLandauer deleted the patch-3 branch January 20, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants