[Validator] Added CssColor constraint #14965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc18710 to
b21f21b
Compare
b21f21b to
d301bfd
Compare
5e2c888 to
4a20f74
Compare
OskarStark
reviewed
Jul 4, 2021
e9f296c to
fa5743e
Compare
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Oct 6, 2021
This PR was merged into the 5.4 branch. Discussion ---------- [Validator] Added `CssColor` constraint | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#14965 This PR introduces a new `CssColor` constraint. It comes with 3 validation modes: - Long, which allows all hexadecimal representation of a color, or 9 (#EEEEEEFF) characters - Short, which only allows hexadecimal colors on 4 (#EEE), 5 (#FFF00) characters - Named colors, which matches [the official list of named colors](https://www.w3.org/TR/css-color-4/#named-color) - HTML5, which allows hexadecimal colors on 7 (#EEEEEE) characters as well as the HTML5 input type color I know that such a color validation already exists in Symfony (in the `ColorType` class), but it's hardcoded in the FormType, and not usable as an assert Annotation. We could decide to remove this hardcoded validation in favor of the new added `CssColor` constraint. Let me know, if yes, I will make the change. Commits ------- b36371c Added new CssColor constraint
symfony-splitter
pushed a commit
to symfony/validator
that referenced
this pull request
Oct 6, 2021
This PR was merged into the 5.4 branch. Discussion ---------- [Validator] Added `CssColor` constraint | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#14965 This PR introduces a new `CssColor` constraint. It comes with 3 validation modes: - Long, which allows all hexadecimal representation of a color, or 9 (#EEEEEEFF) characters - Short, which only allows hexadecimal colors on 4 (#EEE), 5 (#FFF00) characters - Named colors, which matches [the official list of named colors](https://www.w3.org/TR/css-color-4/#named-color) - HTML5, which allows hexadecimal colors on 7 (#EEEEEE) characters as well as the HTML5 input type color I know that such a color validation already exists in Symfony (in the `ColorType` class), but it's hardcoded in the FormType, and not usable as an assert Annotation. We could decide to remove this hardcoded validation in favor of the new added `CssColor` constraint. Let me know, if yes, I will make the change. Commits ------- b36371c06e Added new CssColor constraint
|
The feature PR has been merged. |
|
It needs some work here to report the last changes (modes instead of mode) from the code. |
f395714 to
10810ad
Compare
|
I don't understand why the CI fails 🤔 |
|
friendly ping @Nyholm can you help? |
OskarStark
reviewed
Oct 8, 2021
OskarStark
reviewed
Oct 8, 2021
OskarStark
reviewed
Oct 8, 2021
OskarStark
reviewed
Oct 8, 2021
OskarStark
reviewed
Oct 8, 2021
OskarStark
reviewed
Oct 8, 2021
OskarStark
reviewed
Oct 8, 2021
OskarStark
requested changes
Oct 8, 2021
|
The CI is correct. The class is called “Constraint” https://github.com/symfony/symfony/blob/5.4/src/Symfony/Component/Validator/Constraint.php |
|
Oh. Sorry. I see now that you import partial FQCN. Ci does not support that (appearently) Feel free to ignore that :) |
10810ad to
70bcc38
Compare
70bcc38 to
fd57353
Compare
fd57353 to
fc1539c
Compare
OskarStark
approved these changes
Oct 8, 2021
|
Thanks Mathieu for working on this feature, this is much appreciated. |
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Oct 12, 2021
…aviereguiluz) This PR was merged into the 5.4 branch. Discussion ---------- [Validator] Some tweaks to CssColor constraint This tweaks the great work made by `@welcoMattic` in symfony#14965. It's mostly minor tweaks ... but I also expanded the "basic usage" example to show the case of not adding any parameters to the constraint, which is a common case when you just want to allow any of the valid CSS color formats. Commits ------- 07e38b7 [Validator] Some tweaks to CssColor constraint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the new
CssColorconstraint, contributed in symfony/symfony#40168