Skip to content

Update docs relating to translation extraction #15063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

natewiebe13
Copy link
Contributor

Update translation extraction docs based on changes from symfony/symfony#40229

Fixes #15061

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

I like this. Please link up to the "Translatable object" section, that will make the sentence read better.

@natewiebe13 natewiebe13 changed the title Update docs relating to translation extraction [FrameworkBundle][Translation] Update docs relating to translation extraction Mar 9, 2021
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im happy with this PR.

I let the docs team help out with the syntax.

@carsonbot carsonbot changed the title [FrameworkBundle][Translation] Update docs relating to translation extraction Update docs relating to translation extraction Mar 25, 2021
@wouterj wouterj force-pushed the fix-15061-translation-extraction-docs branch from 3dc3e2c to 77089fa Compare April 7, 2021 15:48
@wouterj wouterj merged commit d7e7152 into symfony:5.x Apr 7, 2021
wouterj added a commit that referenced this pull request Apr 7, 2021
@wouterj
Copy link
Member

wouterj commented Apr 7, 2021

Thank you @natewiebe13 for providing the docs for your code contribution! Fyi, I've added small notes that this feature is new in 5.3 in dc9e613

@natewiebe13 natewiebe13 deleted the fix-15061-translation-extraction-docs branch April 7, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FrameworkBundle][Translation] Extract translation IDs from all of src
4 participants