Skip to content

[Security] Update description for Access decision strategies #15074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2021
Merged

[Security] Update description for Access decision strategies #15074

merged 1 commit into from
Mar 15, 2021

Conversation

comp64
Copy link
Contributor

@comp64 comp64 commented Mar 7, 2021

Updated the description to reflect the current behavior of the builtin AccessDecisionManager.

@carsonbot carsonbot changed the title Update description for Access decision strategies [Security] Update description for Access decision strategies Mar 12, 2021
@javiereguiluz
Copy link
Member

@comp64 thanks for your contribution.

This looks OK to me, but it'd be amazing if some expert in Symfony Security (e.g. @wouterj or @chalasr) could review this. Mostly about which version should we merge this in (4.4 or 5.2). Thanks!

Updated the description to reflect the current behavior of the builtin AccessDecisionManager.
@wouterj wouterj changed the base branch from 5.2 to 4.4 March 15, 2021 13:01
@wouterj wouterj requested a review from xabbuh as a code owner March 15, 2021 13:01
@wouterj wouterj merged commit e4ec52b into symfony:4.4 Mar 15, 2021
@wouterj
Copy link
Member

wouterj commented Mar 15, 2021

Thank you @comp64! This change is indeed completely correct and applies to all Symfony versions from 2.0 and up. However, we only maintain currently maintained versions, so I merged it into the 4.4 branch. From there, we'll merge it into the newer versions.

Congrats with your first doc contribution and I hope to see you back with other great fixes like this :)

xabbuh added a commit that referenced this pull request Mar 26, 2021
OskarStark added a commit to OskarStark/symfony-docs that referenced this pull request Mar 26, 2021
* 4.4:
  [Validator] Added grouped constraints in `Collection` reference
  [symfony#15074] fix typo
OskarStark added a commit to OskarStark/symfony-docs that referenced this pull request Mar 26, 2021
* 5.2:
  [Validator] Added grouped constraints in `Collection` reference
  [symfony#15074] fix typo
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Mar 27, 2021
* 5.2:
  [Validator] Add missing backticks for constraint option names
  [symfony#13492] satisfy the linter
  [Validator] Added grouped constraints in `Collection` reference
  [symfony#15074] fix typo
  Update rate_limiter.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants