[Notifier] [FakeSms] [FakeChat] Update DSN #15206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
OskarStark
added a commit
to symfony/symfony
that referenced
this pull request
Apr 12, 2021
…keSms and FakeChat (OskarStark) This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] Inject Mailer instead of service locator for FakeSms and FakeChat | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fixes #40731 | License | MIT | Doc PR | symfony/symfony-docs#15206 | Recipe PR | symfony/recipes#930 Until now the locator was not injected and therefore not working. We decided to make the transport name configurable instead of the service_id. [How is it working?](#40739 (comment)) ### Todos * [x] add tests * [x] test in a real project Commits ------- 0f6d507 [Notifier] Inject Mailer instead of service locator for FakeSms and FakeChat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows symfony/symfony#40739