[Form] add tailwindcss form theme docs #15218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c160401 to
c2a4d68
Compare
OskarStark
reviewed
Apr 9, 2021
wouterj
requested changes
Apr 10, 2021
There was a problem hiding this comment.
Thank you @kbond! I think we should be a bit more detailed, but overall this is great :)
Should we add more detailed installation instructions?
I don't think so
Should I include the out of the box screenshot from the PR?
I think that would be nice :)
Should I include the customization demo (code/screenshot) from the PR?
I'm not sure if that adds much tbh
|
Hi Kevin! No pressure but would you be able to find some time to finish this PR? Thanks! |
|
Ah, this one slipped off my list. Will finish it up soon. |
|
Friendly ping Kevin 👋 😃 |
|
Sorry for the extreme delay here. I've updated this PR per the review. |
OskarStark
approved these changes
Aug 16, 2023
5.4 is the lowest maintained docs, sure we need this? |
|
Thank you Kevin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rough 1st draft. Some questions:
I'd appreciate some input/feedback!
Closes #15160, Symfony PR: symfony/symfony#40449