[Notifier] Add docs for Microsoft Teams Options #15232
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
commented
Apr 13, 2021
OskarStark
commented
Apr 13, 2021
OskarStark
commented
Apr 13, 2021
OskarStark
commented
Apr 13, 2021
|
Thanks for this contribution! However, I find the name "options" confusing. In the docs that you linked, they call them "fields" (and sometimes, "properties"). I find it confusing because things like "title" or "bgColor" doesn't seem options, but data/metadata. An option would be used to decide if the title is displayed or not, but the title content is not an option, right? Maybe I'm missing things because I don't use Microsoft Teams. |
|
In notifier we use options term in general 🧐 |
|
Oskar, I wasn't aware of that. Then, let's keep it. Better be consistent at least. Thanks! |
No problem 😃 |
javiereguiluz
approved these changes
Apr 14, 2021
7d1d15d to
9557e5f
Compare
9557e5f to
c90e822
Compare
|
Superseeded by #15288 |
javiereguiluz
added a commit
that referenced
this pull request
Jul 27, 2021
…milKubicki) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [Notifier] Documentation for Microsoft Teams Options Docs for symfony/symfony#40738 Replaces #15232 Commits ------- 3c98ba8 [Notifier] Documentation for Microsoft Teams Options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for symfony/symfony#40738