[ConfigBuilder] Replace all framework config #15269
Conversation
ea01165 to
4d644d1
Compare
|
Only the config reference and messeger left =) |
a8c5161 to
a5f4b3b
Compare
49f1d9b to
acdf609
Compare
|
I cannot figure out why not all errors show in the diff.. I only see the first 5.. |
configuration/env_var_processors.rst
Outdated
|
|
||
| return static function (ContainerBuilder $container, FrameworkConfig $framework) { | ||
| $container->setParameter('env(TRUSTED_HOSTS)', '10.0.0.1,10.0.0.2'); | ||
| $framework->trustedHosts('%env(csv:TRUSTED_HOSTS)%'); |
|
Hm... About the CI not showing all errors. It will not show this error and anything after it. Earlier, it did not show this error and anything after it. It make sense if there were a special character that was being printed, but I dont see any. But all (Btw I urlencode the line breaks to have a multi line comment.) |
545a66a to
3a31028
Compare
c270e59 to
71c6a6b
Compare
There was a problem hiding this comment.
Assuming symfony/symfony#40903 will be merged. This PR is ready for a final review.
| ->defaultSerializer('messenger.transport.symfony_serializer') | ||
| ->symfonySerializer() | ||
| ->format('json') | ||
| ->context('foo', 'bar'); |
There was a problem hiding this comment.
Do we have a better example than this?
…urator (Nyholm) This PR was merged into the 5.3-dev branch. Discussion ---------- [Config] Builder: Remove typehints and allow for EnvConfigurator | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | yes -- maybe | New feature? | no -- maybe =) | Deprecations? | no | Tickets | | License | MIT | Doc PR | When [writing documentation](symfony/symfony-docs#15269 (comment)) we found that we don't really support environment variables in the leaves. Ie, we expect a boolean but you provide `"%env(ENABLE_FOO)%"` This PR will also introduce `ParamConfigurator` to allow parameters to be passed as config. The changes to the generated code: ```diff /** + * `@param` bool|ParamConfigurator $value * `@default` false * `@return` $this */ - public function enabled(bool $value): self + public function enabled($value): self { $this->enabled = $value; return $this; } ``` Commits ------- 59b79d3 [Config] Builder: Remove typehints and allow for EnvConfigurator
|
Wohoo. The code PR is merged. |
|
Is there something I can do to help this PR to get merged? |
|
Sorry it took us some time to merge this. Thanks Tobias! |
aa04e88 to
e57adb9
Compare
|
Thank you for merging. I'll fix the rest now |
This PR will replace all framework configuration with the new ConfigBuilders.