Remove dot which should be escaped on telegram #15420
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, Hope I could help a little after I got stuck with an error message telling me to escape the dot, spend a few minutes trying to solve that, really thinking that the trouble was coming from the configuration and not from the example from the doc. Turns out that telegram wants you to escape the character '.' Should it be escaped in the documentation ? (But is it compatible with others channels ?) Or just removed, leaving the doc with a text that works on all channels ? Cheers
|
This should be fixed on the code side. Can you add a testcase to the bridge against 5.3 branch? |
|
Speaking of this file https://github.com/symfony/symfony/blob/5.4/src/Symfony/Component/Notifier/Bridge/Telegram/TelegramTransport.php ? I can try tomorrow ! |
|
Exactly 👌🏻😎 Thank you |
derrabus
added a commit
to symfony/symfony
that referenced
this pull request
Jun 10, 2021
This PR was squashed before being merged into the 5.3 branch. Discussion ---------- [Notifier] Escape `.` char for Telegram transport | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Hello, The MarkdownV2 parse mode of Telegram has the '.' char as a reserved char when sending a message. It should be escaped but only on this mode because it is not reserved on the others. Link to the original report in the documentation : symfony/symfony-docs#15420 I tried writing a test but couldn't reproduce the error, it does work on a small project however. This is my first PR on Sf, hope I did it correctly. Cheers Commits ------- 0aa0fcb [Notifier] Escape `.` char for Telegram transport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Hope I could help a little after I got stuck with an error message telling me to escape the dot, spend a few minutes trying to solve that, really thinking that the trouble was coming from the configuration and not from the example from the doc.
Turns out that telegram wants you to escape the character '.'
Should it be escaped in the documentation ? (But is it compatible with others channels ?)
Or just removed, leaving the doc with a text that works on all channels ?
Cheers