Skip to content

[Notifier] Add Mailjet Bridge #15436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Notifier] Add Mailjet Bridge #15436

wants to merge 1 commit into from

Conversation

jnadaud
Copy link

@jnadaud jnadaud commented Jun 14, 2021

Mailjet notifier bridge: symfony/symfony#41705

@jnadaud jnadaud mentioned this pull request Jun 14, 2021
Merged
OskarStark
OskarStark reviewed Jun 14, 2021
View reviewed changes
@OskarStark OskarStark added this to the 5.4 milestone Jun 14, 2021
@OskarStark OskarStark added the Waiting Code Merge Docs for features pending to be merged label Jun 14, 2021
@carsonbot carsonbot modified the milestones: 5.4, next Jun 14, 2021
@OskarStark
Copy link
Contributor

It looks like from is mandatory, can you please use user and pass of the dsn then, while I would use Auth token as password and from as user.

Same topic for another bridge: https://github.com/symfony/symfony/pull/41522/files#r644752617

fabpot added a commit to symfony/symfony that referenced this pull request Jul 4, 2021
@fabpot
feature #41705 [Notifier] add Mailjet SMS bridge (jnadaud)
42790be 
This PR was merged into the 5.4 branch.

Discussion
----------

[Notifier] add Mailjet SMS bridge

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License       | MIT
| Doc | symfony/symfony-docs#15436

Adding Mailjet SMS bridge for Notifier component

Commits
-------

ee744e7 [Notifier] add Mailjet SMS bridge
@javiereguiluz javiereguiluz added Status: Reviewed and removed Status: Needs Review Waiting Code Merge Docs for features pending to be merged labels Jul 27, 2021
@javiereguiluz
Copy link
Member

We'll need a rebase here to make it mergeable. Thanks!

@OskarStark OskarStark modified the milestones: next, 5.4 Aug 4, 2021
@OskarStark OskarStark mentioned this pull request Aug 4, 2021
Merged
@OskarStark OskarStark closed this in 0a5c3dc Aug 4, 2021
@OskarStark
Copy link
Contributor

I added it in #15584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

Assignees
No one assigned
Labels
Notifier Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jnadaud @OskarStark @javiereguiluz @carsonbot