Skip to content

Update best_practices.rst #15525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2021
Merged

Update best_practices.rst #15525

merged 1 commit into from
Jul 16, 2021

Conversation

steveclifton
Copy link
Contributor

Add missing text to sentence to improve readability

@OskarStark OskarStark added this to the 4.4 milestone Jul 15, 2021
@steveclifton @javiereguiluz
Update best_practices.rst
e329db9 
Add missing text to sentence
@javiereguiluz javiereguiluz changed the base branch from 5.3 to 4.4 July 16, 2021 07:16
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner July 16, 2021 07:16
@javiereguiluz
Copy link
Member

Thanks Steve ... and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit 0a5c122 into symfony:4.4 Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@steveclifton @javiereguiluz @OskarStark @carsonbot