Skip to content

[Messenger] Document the changes in the delete_after_ack Redis option #15552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2021
Merged

[Messenger] Document the changes in the delete_after_ack Redis option #15552

merged 1 commit into from
Jul 26, 2021

Conversation

javiereguiluz
Copy link
Member

Fixes #15537.

@javiereguiluz javiereguiluz added this to the 5.4 milestone Jul 23, 2021
chalasr
chalasr approved these changes Jul 25, 2021
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Javier.
On 6.0 you can just revert that change, the code removal PR has already been merged symfony/symfony#42245.

@javiereguiluz javiereguiluz merged commit 602d31e into symfony:5.4 Jul 26, 2021
@javiereguiluz javiereguiluz deleted the fix_15537 branch July 26, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Messenger Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[Messenger] [Redis] Prepare turning delete_after_ack to true in 6.0
3 participants
@javiereguiluz @chalasr @carsonbot