Skip to content

Deprecate the get() and has() shortcuts of AbstractController #15609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2021
Merged

Deprecate the get() and has() shortcuts of AbstractController #15609

merged 1 commit into from
Aug 9, 2021

Conversation

javiereguiluz
Copy link
Member

Fixes #15606.

We've been promoting service injection for long, so there weren't many get() occurrences to fix and I couldn't find any has() occurrence from AbstractController.

This PR leaves a get() usage on purpose in the doctrine.rst article because it was removed in another PR: #15607.

@javiereguiluz javiereguiluz added this to the 5.4 milestone Aug 9, 2021
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner August 9, 2021 12:54
@javiereguiluz javiereguiluz merged commit 3fa34a9 into symfony:5.4 Aug 9, 2021
@javiereguiluz javiereguiluz deleted the fix_15606 branch August 9, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[FrameworkBundle] Deprecate AbstractController::get() and has()
2 participants
@javiereguiluz @carsonbot