Skip to content

[Console] Add signal event #15741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Console] Add signal event #15741

wants to merge 2 commits into from

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Aug 23, 2021 •
edited
Loading

@94noni 94noni changed the base branch from 5.4 to 5.3 August 23, 2021 14:38
@94noni 94noni force-pushed the ft-console-signal branch from 16f21b4 to a65cdd5 Compare August 23, 2021 14:39
@94noni 94noni changed the title [Console] Add signal [Console] Add signal event Aug 23, 2021
@94noni 94noni force-pushed the ft-console-signal branch from a65cdd5 to cf610a2 Compare August 23, 2021 15:01
@94noni 94noni force-pushed the ft-console-signal branch from cf610a2 to 1fc1bca Compare August 23, 2021 15:05
@94noni
Copy link
Contributor Author

94noni commented Sep 15, 2021

Friendly ping @lyrixx @javiereguiluz related to the issue linked, thx :)

@javiereguiluz
Copy link
Member

Antoine, thanks a lot for this contribution! Sadly, there was a prior similar contribution (#15717) and we merged that (and did some tweaks and additions while merging, so the result is very similar to your pull request). I'm sorry!

@javiereguiluz javiereguiluz mentioned this pull request Sep 23, 2021
Closed
@94noni 94noni deleted the ft-console-signal branch September 23, 2021 14:58
@94noni
Copy link
Contributor Author

94noni commented Sep 23, 2021

Perfect :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Console] Add signal event
5 participants
@94noni @javiereguiluz @lyrixx @carsonbot @noniagriconomie