Skip to content

[Mailer] Added OhMySMTP mailer details #15747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[Mailer] Added OhMySMTP mailer details #15747

wants to merge 6 commits into from

Conversation

paul-oms
Copy link
Contributor

@paul-oms paul-oms commented Aug 24, 2021

@carsonbot
Copy link
Collaborator

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@OskarStark OskarStark added the Waiting Code Merge Docs for features pending to be merged label Aug 25, 2021
@carsonbot carsonbot added this to the next milestone Aug 25, 2021
@OskarStark OskarStark modified the milestones: next, 5.4 Aug 25, 2021
fabpot added a commit to symfony/symfony that referenced this pull request Aug 26, 2021
This PR was squashed before being merged into the 5.4 branch.

Discussion
----------

[Mailer] Added OhMySMTP Bridge

This adds the https://ohmysmtp.com bridge to enable sending over the [OhMySMTP](https://ohmysmtp.com) API.

| Q             | A
| ------------- | ---
| Branch?       | 5.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | none <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#15747... <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch 5.x.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
-->

Commits
-------

ce72fd8 [Mailer] Added OhMySMTP Bridge
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Aug 26, 2021
This PR was squashed before being merged into the 5.4 branch.

Discussion
----------

[Mailer] Added OhMySMTP Bridge

This adds the https://ohmysmtp.com bridge to enable sending over the [OhMySMTP](https://ohmysmtp.com) API.

| Q             | A
| ------------- | ---
| Branch?       | 5.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | none <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#15747... <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch 5.x.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
-->

Commits
-------

ce72fd8411 [Mailer] Added OhMySMTP Bridge
@paul-oms paul-oms requested a review from OskarStark August 26, 2021 14:28
@javiereguiluz
Copy link
Member

@paul-oms thanks for adding these contents ... and congrats on your first Symfony Docs contribution 🎉

javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Aug 30, 2021
This PR was squashed before being merged into the 5.4 branch.

Discussion
----------

[Mailer] Added OhMySMTP mailer details

Refs symfony/symfony#42710

Commits
-------

b3dc6a8 [Mailer] Added OhMySMTP mailer details
@javiereguiluz javiereguiluz removed the Waiting Code Merge Docs for features pending to be merged label Aug 30, 2021
@javiereguiluz
Copy link
Member

I'm closing this manually because the tool we use didn't close it automatically, as usual.

I don't know the reason, because this looks like it was merged correctly in 5.4 (and 6.0) --> https://github.com/symfony/symfony-docs/commits/5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants