Skip to content

Add a note on "--no-plugins" Composer option effects on runtime component #15800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

andrea-cristaudo
Copy link
Contributor

No description provided.

@IonBazan
Copy link

I think you should rebase your commit onto 4.4 and target that branch too. Currently your PR contains changes from 5.4 and targets 5.3 which is incorrect.

git checkout 4.4
git cherry-pick 8bc6ed9
git push origin 4.4:patch-1 -f 

@andrea-cristaudo
Copy link
Contributor Author

I think you should rebase your commit onto 4.4 and target that branch too. Currently your PR contains changes from 5.4 and targets 5.3 which is incorrect.

git checkout 4.4
git cherry-pick 8bc6ed9
git push origin 4.4:patch-1 -f 

Thanks.
Since symfony/runtime is a 5.3 new component I thought 5.3 was the right target branch.

@IonBazan
Copy link

Sorry, you're right, should be 5.3!

When you use the "--no-plugins" Composer option the autoload_runtime.php file won't be created.
@javiereguiluz javiereguiluz changed the base branch from 5.3 to 5.4 March 22, 2022 08:06
@javiereguiluz javiereguiluz merged commit 9dd96b2 into symfony:5.4 Mar 22, 2022
@javiereguiluz
Copy link
Member

Thanks Andrea! This is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants