Skip to content

[Console] Add support of RGB functional notation to output colors #15833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Sep 19, 2021

Waiting code merge of symfony/symfony#43094

@OskarStark OskarStark added the Waiting Code Merge Docs for features pending to be merged label Sep 19, 2021
@carsonbot carsonbot added this to the next milestone Sep 19, 2021
@OskarStark OskarStark modified the milestones: next, 5.4 Sep 19, 2021
fabpot added a commit to symfony/symfony that referenced this pull request Sep 21, 2021
…andre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Console] Add support of RGB functional notation

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | _NA_
| License       | MIT
| Doc PR        | symfony/symfony-docs#15833

Commits
-------

8f76128 [Console] Add support of RGB functional notation for output colors
@javiereguiluz javiereguiluz added Status: Reviewed and removed Waiting Code Merge Docs for features pending to be merged Status: Needs Review labels Sep 22, 2021
@javiereguiluz javiereguiluz merged commit 8d1a53e into symfony:5.4 Sep 22, 2021
@javiereguiluz
Copy link
Member

This was a nice addition! Thanks Alexandre.

@ogizanagi
Copy link
Contributor

As symfony/symfony#43094 was reverted, this should be reverted as well

javiereguiluz added a commit that referenced this pull request Sep 29, 2021
…reguiluz)

This PR was merged into the 5.4 branch.

Discussion
----------

[Console] Revert RGB notation in console coloring

As `@ogizanagi` said in #15833 (comment), this change was ultimately reverted, so let's revert the docs too.

Commits
-------

213d725 [Console] Revert RGB notation in console coloring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants