Constructor property promotion - part 1 #16087
Conversation
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
|
@wkania thanks a lot for proposing this change. We've been discussing about this internally in the Symfony Docs Team. We've decided to not merge this change yet. It's true that Symfony 6 requires PHP 8 and you can do this, but we prefer to not do it yet. This feature is too new and changes code significantly ... and the result isn't pleasant for everybody yet. We need more time until most people start using this notation and get used to it. So, we're closing without merging for those reasons. Thanks! |
|
@javiereguiluz I see. Thx for giving all reasons behind this decision. |
PHP 8 is min. version for the Symfony 6 so let's use Constructor property promotion.
It's part 1, because when last time I edited 60+ files, the PR was waiting to be merged for months :).