[Notifier] [Bridge] [KazInfoTeh] added bridge documentation #16088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
requested changes
Dec 1, 2021
notifier.rst
Outdated
| @@ -87,6 +87,7 @@ Telnyx ``symfony/telnyx-notifier`` ``telnyx://API_KEY@default | |||
| TurboSms ``symfony/turbo-sms-notifier`` ``turbosms://AUTH_TOKEN@default?from=FROM`` | |||
| Twilio ``symfony/twilio-notifier`` ``twilio://SID:TOKEN@default?from=FROM`` | |||
| Yunpian ``symfony/yunpian-notifier`` ``yunpian://APIKEY@default`` | |||
| KazInfoTeh ``symfony/kazinfoteh-notifier`` ``kazinfoteh://username:password@default?sender=FROM`` | |||
There was a problem hiding this comment.
Please move above LightSms to keep alphanumeric order, thanks
and
Suggested change
| KazInfoTeh ``symfony/kazinfoteh-notifier`` ``kazinfoteh://username:password@default?sender=FROM`` | |
| KazInfoTeh ``symfony/kazinfoteh-notifier`` ``kazinfoteh://USERNAME:PASSWORD@default?sender=FROM`` |
There was a problem hiding this comment.
@fabpot I guess the correct package name would be:
- symfony/kazinfothe-notifier
+ symfony/kaz-info-the-notifierCan you please confirm?
There was a problem hiding this comment.
The correct spelling would be symfony/kaz-info-teh-notifier. teh it's abbreviation from technology in Russian.
There was a problem hiding this comment.
Sorry ofc you are right I misspelled it 👍🏻
|
Please target |
|
Please add a versionadded:: 6.1 block, thanks You can check 5.4 branch for reference |
OskarStark
approved these changes
Dec 7, 2021
|
This branch needs a rebase please |
OskarStark
reviewed
Jan 19, 2022
OskarStark
approved these changes
Jan 19, 2022
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jan 19, 2022
…anovegor) This PR was merged into the 6.1 branch. Discussion ---------- [Notifier] [Bridge] [KazInfoTeh] added the bridge | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | symfony/symfony-docs#16088 | Recipe | symfony/recipes#1031 This is a notifier bridge for Kazakh SMS provider KazInfoTeh. Commits ------- d500adc [Notifier] [Bridge] [KazInfoTeh] added the bridge
|
Thanks for your work on this new feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Notifier bridge for kazinfoteh.kz
symfony/symfony#44360