-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Messenger] Redis Sentinel support #16113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Messenger] Redis Sentinel support #16113
Conversation
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
Thanks for this contribution! If you can, please update your PR to remove the changes introduced in the first part of the table (the existing contents). The changes in the headers especially caused some troubles for us in the past (because of the leading white spaces ... so we must keep the current contents). Also, after the updated table, please add the following: .. versionadded:: 5.4
The ``sentinel_persistent_id``, ``sentinel_retry_interval``, ``sentinel_read_timeout``,
``sentinel_timeout``, and ``sentinel_master`` options were introduced in Symfony 5.4. |
4a0be7d
to
144f91a
Compare
144f91a
to
c4fe71f
Compare
Made some adjustments on the content but I am affraid due to the length of the argument names I can't undo the changes on the table header. But if I am missing something about rst tables please give a hand |
Norbert, thanks for creating this Pull Request and thanks for the changes after the first review. Tables in RST format are a bit tricky, but I was mostly referring to the extra white space before the contents of the headers: But don't worry, we have fixed this while merging, so everything is OK. Congrats on your first Symfony Docs contribution 🎉 |
…eisz) This PR was merged into the 6.1 branch. Discussion ---------- [Messenger] Add Redis Sentinel support | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Issue #41762 | License | MIT | Doc PR | symfony/symfony-docs#16113 Commits ------- 6c5f289 [Messenger] cleanup creation logic in Redis Connection class 07de048 [Messenger] [Redis] Redis Sentinel support - issue #41762
This has just been merged in 6.1 (not 5.4), and the name of the options have been changed. @norbertschultheisz could you please send a PR on 6.1 to fix this there? Then we should revert this from 5.4. |
sure, gonna update everything |
…aters with co… (norbertschultheisz) This PR was merged into the 6.1 branch. Discussion ---------- [Messenger] Fix: Redis Sentinel support - aligning paramaters with co… [Messenger] Fix: Redis Sentinel support - aligning paramaters with constructor original PR [https://github.com/symfony/symfony-docs/pull/16113](https://github.com/symfony/symfony-docs/pull/16113) Commits ------- c6543ea [Messenger] Fix: Redis Sentinel support - aligning paramaters with contructor
No description provided.