Skip to content

[Form] Adding group_by #16179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ThomasLandauer
Copy link
Contributor

I didn't check if others are missing too...

I didn't check if others are missing too...
@carsonbot carsonbot added this to the 5.4 milestone Nov 30, 2021
@xabbuh
Copy link
Member

xabbuh commented Dec 1, 2021

Would it make sense to move all options out of the ChoiceType into a dedicated file and include that one everywhere where we need to render these options? This would also reduce the risk of forgetting any of them in the future once new options are added.

@ThomasLandauer
Copy link
Contributor Author

ThomasLandauer commented Dec 13, 2021

Sorry, I don't know what's the best way to organize this :-(

But choice_label is missing too.

@javiereguiluz
Copy link
Member

I'm closing this PR because this page added the group_by option a while ago (see https://symfony.com/doc/current/reference/forms/types/enum.html#group-by).

Also, we can't easily do what Christian proposed here because the list of options have cross-references that are used in many other docs, and moving all that to includes, would break the references.

Thanks.

@ThomasLandauer ThomasLandauer deleted the patch-24 branch June 20, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants