Skip to content

Adding docs for Stimulus, Turbo & Symfony UX #16323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

weaverryan
Copy link
Member

Hi!

A long overdue PR to update the Encore section to reflect Stimulus & Symfony UX.

Cheers!

@weaverryan
Copy link
Member Author

Failure should be fixed by: symfony-tools/code-block-checker#43

javiereguiluz added a commit to javiereguiluz/code-block-checker that referenced this pull request Dec 27, 2021
This PR was squashed before being merged into the main branch.

Discussion
----------

Adding 3 Stimulus Twig functions

Related: symfony/symfony-docs#16323

Commits
-------

2fe211a Adding 3 Stimulus Twig functions
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new docs are very nice. Thanks for this contribution!

@weaverryan
Copy link
Member Author

FYI - to get the tests to pass, I had to update the CI to grab @dev of https://github.com/symfony-tools/code-block-checker. We could do that, or tag that library... but I'm not sure tags are needed on that lib if its only purpose is for the docs' CI.

@javiereguiluz
Copy link
Member

Ryan, thanks a lot for this nice update!

@javiereguiluz javiereguiluz merged commit 225dc1c into symfony:5.4 Jan 7, 2022
@weaverryan weaverryan deleted the ux-docs branch January 12, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants