-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Update configuration.rst and deployment.rst for dotenv:dump command #16416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! This command is a bit special, as we need to register it first (see the PR description in symfony/symfony#42610 (comment)):
I think we should document this only once, in the configuration article. And then in the deployments article, we should only add a small tip like: "If Composer is not available during deployment, you can also use the |
Hi, If I get the PR description without changing it and put it into the configuration documentation directly, do you mind? Because it is really good enough explicit. I'll add the following tip in the deployment but how can I handle "read ... for more information"? Should I give the "configuration" page URL directly there? "If Composer is not available during deployment, you can also use the dotenv:dump command. Read ... for more information." |
Fine by me (I would replace "one must" with "you must" though).
You can use |
hi @wouterj Thanks for the answer. I have got a quick question regarding deployment.rst. We edited it like the image. Should we add composer tip here? Because we already recommend using dotenv command for dumping. |
I think we can keep composer at first, and then reference the configuration section to say "if you don't have composer, use this command". Anyway, feel free to update the PR as you like it best. We can apply little reorganizations during the merge, if we think something else is better. |
Mert, thanks for this contribution! While merging I did the final change asked by Wouter (see 679be09) |
Brilliant! Thank you actually. |
It changes from "composer dump-env prod" to "php bin/console dotenv:dump prod"