Skip to content

Update extension.rst #16443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2022
Merged

Update extension.rst #16443

merged 1 commit into from
Jan 25, 2022

Conversation

issamkhadiri1989
Copy link
Contributor

when using DependencyInjection\Extension\Extension, the addAnnotatedClassesToCompile is not available. so it should be mentionned that we need to use HttpKernel\DependencyInjection\Extension instead when the method addAnnotatedClassesToCompile must be used

@issamkhadiri1989 @wouterj
Update extension.rst
7e3106b 
when using  `DependencyInjection\Extension\Extension`, the `addAnnotatedClassesToCompile` is not available. so it should be mentionned that we need to use `HttpKernel\DependencyInjection\Extension` instead when the method `addAnnotatedClassesToCompile`  must be used
@wouterj wouterj changed the base branch from 6.0 to 4.4 January 25, 2022 12:45
@wouterj
Copy link
Member

wouterj commented Jan 25, 2022

Thank you @issamkhadiri1989! Looks like Symfony's bundles also use the HttpKernel version, so this change seems 100% correct. Congratz with your first doc contribution :)

@wouterj wouterj merged commit c8e3422 into symfony:4.4 Jan 25, 2022
@issamkhadiri1989
Copy link
Contributor Author

Hello @wouterj

I really appreciate your feedback and very pleased that i could contribute to this amazing doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark Awaiting requested review from OskarStark

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@issamkhadiri1989 @wouterj @carsonbot