Skip to content

[Cache] 45036 add stale while revalidate and stale if error support #16445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

remilemonnier
Copy link

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

This PR allow support for RFC5861.
Meaning you can now use stale_while_revalidate and stale_if_error
https://httpwg.org/specs/rfc5861.html

Very interesting doc from Fastly on the subject:
https://developer.fastly.com/learning/concepts/stale/

@carsonbot carsonbot added this to the 5.4 milestone Jan 25, 2022
@carsonbot carsonbot changed the title [cache] 45036 add stale while revalidate and stale if error support [Cache] 45036 add stale while revalidate and stale if error support Jan 25, 2022
@javiereguiluz javiereguiluz added the Waiting Code Merge Docs for features pending to be merged label Mar 25, 2022
fabpot added a commit to symfony/symfony that referenced this pull request Mar 26, 2022
…er (remieuronews)

This PR was merged into the 6.1 branch.

Discussion
----------

[HttpFoundation] add stale while revalidate cache header

| Q             | A
| ------------- | ---
| Branch?       | 6.1
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Feat (#45036)
| License       | MIT
| Doc PR       | [symfony/symfony-docs#... <!-- required for new features -->](symfony/symfony-docs#16445)

This PR allow support for RFC5861.
Meaning you can now use stale_while_revalidate and stale_if_error
https://httpwg.org/specs/rfc5861.html

Very interesting doc from Fastly on the subject:
https://developer.fastly.com/learning/concepts/stale/

Link to the issue
#45036

Commits
-------

db553fb [cache] #45109 add stale while revalidate and stale if error cache header
symfony-splitter pushed a commit to symfony/http-foundation that referenced this pull request Mar 26, 2022
…er (remieuronews)

This PR was merged into the 6.1 branch.

Discussion
----------

[HttpFoundation] add stale while revalidate cache header

| Q             | A
| ------------- | ---
| Branch?       | 6.1
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Feat (symfony/symfony#45036)
| License       | MIT
| Doc PR       | [symfony/symfony-docs#... <!-- required for new features -->](symfony/symfony-docs#16445)

This PR allow support for RFC5861.
Meaning you can now use stale_while_revalidate and stale_if_error
https://httpwg.org/specs/rfc5861.html

Very interesting doc from Fastly on the subject:
https://developer.fastly.com/learning/concepts/stale/

Link to the issue
symfony/symfony#45036

Commits
-------

db553fb9f3 [cache] #45109 add stale while revalidate and stale if error cache header
@javiereguiluz javiereguiluz removed the Waiting Code Merge Docs for features pending to be merged label Apr 8, 2022
@javiereguiluz javiereguiluz modified the milestones: 5.4, 6.1 Apr 8, 2022
@javiereguiluz javiereguiluz changed the base branch from 5.4 to 6.1 April 8, 2022 14:45
@javiereguiluz javiereguiluz force-pushed the feat/45036-add-stale-while-revalidate-header branch from 108cd38 to 995b2e6 Compare April 8, 2022 14:45
@javiereguiluz javiereguiluz merged commit 1c402b6 into symfony:6.1 Apr 8, 2022
@javiereguiluz
Copy link
Member

Rémi, thanks for implementing this feature and contributing the docs for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants