[DependencyInjection] Fix YAML example in "Defining a Service Locator" section #16458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Service locator is a first constructor argument but is passed as an array of constructor arguments.
|
Good catch Justas! Thanks and congrats on your first Symfony Docs contribution 🎉 |
|
@javiereguiluz Will this change be applied to other versions like 5.x, 6.x? |
|
Yes, it should be already in all upper and maintained branches. We "upmerge" all Pull Requests. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this example in
v5.3.13gives this error:I assume this is because
!service_locatoris the first constructor argument but it's passed as an array of constructor arguments, in which case the example is not right.