Skip to content

[Messenger] fix(middleware): DoctrineBridge middleware #16535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Messenger] fix(middleware): DoctrineBridge middleware #16535

wants to merge 1 commit into from

Conversation

Guikingone
Copy link
Contributor

Hi 👋🏻

It seems that the documentation mention the DoctrineBundle which is not in charge of adding middleware as they're defined in the bridge: https://github.com/symfony/symfony/tree/6.1/src/Symfony/Bridge/Doctrine/Messenger

Thanks for the feedback and have a great day 🙂

@carsonbot carsonbot added this to the 4.4 milestone Feb 22, 2022
@Guikingone Guikingone changed the title fix(middleware): DoctrineBridge fix(middleware): DoctrineBridge middleware Feb 22, 2022
@javiereguiluz
Copy link
Member

@Guikingone thanks for fixing this.

I was checking, and these middleware are available at least since Symfony 4.3 (see https://github.com/symfony/symfony/tree/4.3/src/Symfony/Bridge/Doctrine/Messenger). So, there shouldn't be any need to add a versionadded directive in 4.4 and up and we could delete this entirely. What do you think?

@carsonbot carsonbot changed the title fix(middleware): DoctrineBridge middleware [Messenger] fix(middleware): DoctrineBridge middleware Oct 5, 2022
@HeahDude
Copy link
Contributor

I agree with @javiereguiluz, we should delete this directive and target 5.4.

@OskarStark OskarStark mentioned this pull request Aug 14, 2023
Merged
@OskarStark
Copy link
Contributor

PR created

OskarStark added a commit that referenced this pull request Aug 14, 2023
@OskarStark
minor #18746 [Messenger] Delete obsolete versionadded directive (Os…
9d3d697 
…karStark)

This PR was merged into the 5.4 branch.

Discussion
----------

[Messenger] Delete obsolete `versionadded` directive

Fixes #16535

Commits
-------

a942926 [Messenger] Delete obsolete `versionadded` directive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Messenger Status: Needs Review Waiting feedback
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Guikingone @javiereguiluz @HeahDude @OskarStark @carsonbot