Skip to content

[Logging] Document the Monolog reset() method for long running processes #16609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2023
Merged

[Logging] Document the Monolog reset() method for long running processes #16609

merged 1 commit into from
Mar 8, 2023

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Mar 16, 2022

Close #15086

@carsonbot carsonbot added this to the 5.4 milestone Mar 16, 2022
@GromNaN
Copy link
Member

GromNaN commented Mar 16, 2022 •
edited
Loading

buffer_size for finger_crossed can be mentioned.
https://github.com/symfony/recipes/blob/master/symfony/monolog-bundle/3.7/config/packages/monolog.yaml#L48

GromNaN
GromNaN reviewed Mar 16, 2022
View reviewed changes
Seldaek
Seldaek reviewed May 3, 2022
View reviewed changes
@Seldaek Seldaek mentioned this pull request May 3, 2022
Closed
@kbond
Copy link
Member

kbond commented May 3, 2022

To clarify, this is handled automatically when consuming messenger messages, correct?

@Seldaek
Copy link
Member

Seldaek commented May 3, 2022

Yes I believe so as of symfony/symfony#40761

@94noni
Copy link
Contributor Author

94noni commented Nov 9, 2022

@GromNaN as early reviewer, do you see something else to add on this PR? thank you

@OskarStark OskarStark changed the title [Logging] Document the Monolog reset() for long running processes [Logging] Document the Monolog reset() method for long running processes Nov 9, 2022
@GromNaN
Copy link
Member

GromNaN commented Nov 9, 2022

All good. I'm wondering why this is not automatic.

@OskarStark
Copy link
Contributor

Should be against 4.4

@94noni 94noni changed the base branch from 5.4 to 4.4 November 9, 2022 15:31
@94noni 94noni requested a review from xabbuh as a code owner November 9, 2022 15:31
@94noni 94noni changed the base branch from 4.4 to 5.4 November 9, 2022 15:31
@94noni
Copy link
Contributor Author

94noni commented Nov 9, 2022

@OskarStark fair enough, will handle it soon :)
thx @GromNaN for answer

@94noni
Copy link
Contributor Author

94noni commented Mar 6, 2023

v4 is eol, thus this PR is reviewable as it is

@OskarStark
Copy link
Contributor

Thanks Antoine.

@OskarStark OskarStark merged commit 59b5689 into symfony:5.4 Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seldaek Seldaek Seldaek left review comments

@GromNaN GromNaN GromNaN left review comments

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[Logging] Please advise people to use reset() for long running processes
6 participants
@94noni @GromNaN @kbond @Seldaek @OskarStark @carsonbot