Skip to content

[Finder] Add case insensitive sort #16735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 152 commits into from
Closed

[Finder] Add case insensitive sort #16735

wants to merge 152 commits into from

Conversation

hmoreau
Copy link
Contributor

@hmoreau hmoreau commented Apr 20, 2022

Add a second argument to sortByName() method to select between case sensitive and case insensitive sort.

@carsonbot carsonbot added this to the 6.1 milestone Apr 20, 2022
@OskarStark OskarStark added the Waiting Code Merge Docs for features pending to be merged label Apr 21, 2022
@carsonbot carsonbot modified the milestones: 6.1, next Apr 21, 2022
BahmanMD and others added 23 commits June 2, 2022 16:02
This PR was squashed before being merged into the 6.2 branch.

Discussion
----------

Update setup.rst ( version 6.2 )

Commits
-------

b7438ff Update setup.rst ( version 6.2 )
* 6.1:
  Fix: Use correct SF version
* 6.1:
  [HtmlSanitizer] Fix wrong method name
* 6.1:
  Add the versionadded directive
  Add information about DateTimeValueResolver
* 6.1:
  Fix options path in composer.json
* 6.1:
  [Frontend] Remove an unused reference
…aviereguiluz)

This PR was merged into the 6.2 branch.

Discussion
----------

[Security] Move the Security helper to SecurityBundle

Fixes #16846.

Commits
-------

c7369d5 [Security][SecurityBundle] Move the Security helper to SecurityBundle
* 6.1:
  Fix second twig path reference to be consistent with the first reference on security documentation
* 6.1:
  [HtmlSanitizer] Fix a few typos in the introduction
* 6.1:
  Remove the deprecated SetUpTearDownTrait feature
  [PhpUnitBridge] Mention the SetUpTearDownTrait deprecation
* 6.1:
  Add assets to the documentation
  add caution to URL-encode special characters in Notifier DSNs
  [Form][NumberType] Fix constants
  Fix development testing examples
* 6.1:
  [Validator] Update validation.rst
This PR was squashed before being merged into the 6.2 branch.

Discussion
----------

[Security] Enforce maximum username length

Fixes #16856.

Commits
-------

0e14ecf [Security] Enforce maximum username length
* 6.1:
  [Notifier] Added the Engagespot push notification
* 6.1:
  Update questionhelper.rst
  Reword
  hint about creating config/routes/annotations.yaml as well, when using attributes without doctrine/annotations.
* 6.1:
  [Doctrine] Add attribute example for Lifecycle Callbacks
* 6.1:
  Use HTML syntax highlighting
  Update http_kernel_httpkernelinterface.rst
* 6.1:
  [Translation] Update locale.rst
* 6.1:
  Remove deprecated Docs ind "lock"
* 6.1:
  [Frontend] Update UX package list
  New features must go on the 6.x branch
fabpot and others added 10 commits July 27, 2022 11:11
…(fabpot)

This PR was merged into the 6.2 branch.

Discussion
----------

[Mailer] Add more information about sending email async

The example only works as of 6.2 thanks to symfony/symfony#47075

I've written this PR because we keep having issues like symfony/symfony#44439.
So, documenting a bit more how it works internally might help people understand what to do.

Commits
-------

4fbbc16 Add more information about sending email async
* 6.1:
  [Routing] Fix some internal references links
  Add links to each Symfony UX component demo
  Linking to ux.symfony.com
* 6.1:
  [Messenger] fix broken link to Validator component
* 6.1:
  Update mercure.rst
  [HttpKernel] Add UidValueResolver to the list of built-in value resolvers
  Adding missing `use`s
* 6.1:
  Be more detailed about coding standards for PHPdoc
* 6.1:
  Update README.markdown
* 6.1:
  Adding class constants
* 6.1:
  [ExpressionLanguage] Feature Null-coalescing operator
@javiereguiluz javiereguiluz removed the Waiting Code Merge Docs for features pending to be merged label Jul 29, 2022
@javiereguiluz
Copy link
Member

@hmoreau thanks for this contribution! Will you have some time to rebase this PR into 6.2 branch and remove the unrelated commits? Thanks!

@hmoreau hmoreau closed this Jul 29, 2022
@hmoreau
Copy link
Contributor Author

hmoreau commented Jul 29, 2022

Sure, rebase is done

@xabbuh xabbuh reopened this Jul 30, 2022
@xabbuh xabbuh modified the milestones: next, 6.2 Jul 30, 2022
* 6.1:
  fix reference markup
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look alike the rebase does not worked 🤔

@hmoreau hmoreau requested a review from xabbuh as a code owner July 31, 2022 19:41
@hmoreau
Copy link
Contributor Author

hmoreau commented Jul 31, 2022

Here is what I did :

git remote add upstream https://github.com/symfony/symfony-docs.git
git fetch upstream
git rebase upstream/6.2
git push

Is there something else to do ?

@OskarStark
Copy link
Contributor

You rebased on 6.2, but the target branch of this PR is 6.1

@hmoreau
Copy link
Contributor Author

hmoreau commented Jul 31, 2022

Oh yes you are right, thank you.
I tried to change to 6.2, but I got the error :
There are no new commits between base branch '6.2' and head branch 'CASE_INSENSITIVE_FILE_LIST'

@hmoreau
Copy link
Contributor Author

hmoreau commented Jul 31, 2022

May be it is easier if I make a new PR from scratch?

@javiereguiluz
Copy link
Member

@hmoreau yes please, create a new PR with the right commit with your changes. Thanks!

hmoreau added a commit to hmoreau/symfony-docs that referenced this pull request Aug 9, 2022
Add a new sortByCaseInsensitiveName() method to have case insensitive sorting results.
Like the sortByName(), pass true as its argument to use PHP's case insensitive natural sort order algorithm instead.

Related to #46126 PR
Replace symfony#16735 PR
javiereguiluz added a commit that referenced this pull request Aug 9, 2022
This PR was squashed before being merged into the 6.2 branch.

Discussion
----------

[Finder] Add case insensitive sort

Add a new sortByCaseInsensitiveName() method to have case insensitive sorting results.
Like the sortByName(), pass true as its argument to use PHP's case insensitive natural sort order algorithm instead.

Related to symfony/symfony#46126 PR
Replace #16735 PR

Commits
-------

df9281f [Finder] Add case insensitive sort
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.