Skip to content

[Notifier] Add docs for FlashMessageImportanceMapper #16776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2022
Merged

[Notifier] Add docs for FlashMessageImportanceMapper #16776

merged 1 commit into from
May 5, 2022

Conversation

benr77
Copy link
Contributor

@benr77 benr77 commented May 4, 2022

Add missing documentation for FlashMessageImportanceMapper (#16654)

@carsonbot carsonbot added this to the 6.1 milestone May 4, 2022
@benr77 benr77 force-pushed the 16654_add_flash_message_importance_mapper_docs branch from b5e0c49 to f261939 Compare May 4, 2022 07:18
@wouterj wouterj linked an issue May 4, 2022 that may be closed by this pull request
[Notifier] Use Importance level to set flash message type #16654
Closed
wouterj
wouterj approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've made a few suggestions, but it's ready to merge imho.

@benr77 benr77 force-pushed the 16654_add_flash_message_importance_mapper_docs branch from f261939 to ad4ce60 Compare May 5, 2022 06:21
@benr77 benr77 force-pushed the 16654_add_flash_message_importance_mapper_docs branch from ad4ce60 to 7e0fb3e Compare May 5, 2022 06:23
@carsonbot carsonbot changed the title Add docs for FlashMessageImportanceMapper [Notifier] Add docs for FlashMessageImportanceMapper May 5, 2022
@javiereguiluz javiereguiluz merged commit 9e5ec28 into symfony:6.1 May 5, 2022
@javiereguiluz
Copy link
Member

Ben, thanks for adding the docs of this feature ... and congrats on your first Symfony Docs contribution 🎉

@benr77 benr77 deleted the 16654_add_flash_message_importance_mapper_docs branch May 5, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
Notifier Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.

[Notifier] Use Importance level to set flash message type
4 participants
@benr77 @javiereguiluz @wouterj @carsonbot