Skip to content

[HtmlSanitizer] Document the new component #16787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2022
Merged

[HtmlSanitizer] Document the new component #16787

merged 1 commit into from
May 20, 2022

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented May 5, 2022 •
edited
Loading

Fixes #16332, fixes #16716, fixes #16804

A first start with the documentation for the new HTML sanitizer component. I'm using the same style as we did in the HttpClient documentation, as I think that worked pretty well.

cc @tgalopin

@carsonbot carsonbot changed the title [HTML Sanitizer] Document the new component [HtmlSanitizer] [HTML Sanitizer] Document the new component May 5, 2022
@wouterj wouterj changed the title [HtmlSanitizer] [HTML Sanitizer] Document the new component [HtmlSanitizer] Document the new component May 5, 2022
@wouterj wouterj force-pushed the issue-16332/html-sanitizer branch from 9928a9b to a462bfb Compare May 5, 2022 22:11
@wouterj wouterj added this to the 6.1 milestone May 5, 2022
This was linked to issues May 5, 2022
[FrameworkBundle] Integrate the HtmlSanitizer component #16716
Closed
[HtmlSanitizer] Introduce HtmlSanitizer component #16332
Closed
@wouterj wouterj force-pushed the issue-16332/html-sanitizer branch from a462bfb to 3fc1260 Compare May 5, 2022 22:14
javiereguiluz
javiereguiluz reviewed May 6, 2022
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouter, thanks a lot for working on this big contribution ❤️

@wouterj wouterj force-pushed the issue-16332/html-sanitizer branch from 3fc1260 to 797a827 Compare May 7, 2022 12:18
@wouterj wouterj marked this pull request as ready for review May 7, 2022 12:18
@wouterj wouterj requested a review from xabbuh as a code owner May 7, 2022 12:18
@wouterj wouterj force-pushed the issue-16332/html-sanitizer branch 2 times, most recently from a9639e8 to 52c4ca2 Compare May 7, 2022 12:23
@wouterj
Copy link
Member Author

wouterj commented May 7, 2022 •
edited
Loading

Thanks Javier. I've fixed the syntax errors and finished the configuration sections (lots of copy past 😓).

@wouterj wouterj force-pushed the issue-16332/html-sanitizer branch from 52c4ca2 to c7c2c5e Compare May 9, 2022 11:04
tgalopin
tgalopin approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@tgalopin tgalopin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks so much Wouter!

@wouterj wouterj force-pushed the issue-16332/html-sanitizer branch from c7c2c5e to 483306d Compare May 10, 2022 18:24
@wouterj
Copy link
Member Author

wouterj commented May 10, 2022

Thanks @tgalopin!

nicolas-grekas
nicolas-grekas reviewed May 12, 2022
View reviewed changes
@nicolas-grekas
Copy link
Member

There is also symfony/symfony#46335 to account for now (would close #16804)

@wouterj wouterj force-pushed the issue-16332/html-sanitizer branch from 483306d to 0dfdcab Compare May 16, 2022 19:42
@wouterj wouterj linked an issue May 16, 2022 that may be closed by this pull request
[Form][FrameworkBundle][TwigBundle] Add Twig filter, form-type extensio… #16804
Closed
@wouterj
Copy link
Member Author

wouterj commented May 16, 2022

PR updated to include #16804

@wouterj wouterj force-pushed the issue-16332/html-sanitizer branch from 0dfdcab to 5f3cfeb Compare May 16, 2022 19:48
@javiereguiluz
Copy link
Member

This is great! Thank you Wouter for this massive contribution 🙇 It's merged now 🥳

@javiereguiluz javiereguiluz merged commit 7ba0c87 into symfony:6.1 May 20, 2022
@wouterj wouterj deleted the issue-16332/html-sanitizer branch May 20, 2022 14:15
@wouterj
Copy link
Member Author

wouterj commented May 20, 2022

Thank you Javier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@tgalopin tgalopin tgalopin approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
HtmlSanitizer Status: Reviewed
Projects
None yet
Milestone
6.1
5 participants
@wouterj @nicolas-grekas @javiereguiluz @tgalopin @carsonbot