[Serializer] Update serializer example using type hints #16876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this proposal. @wouterj do you agree on adding this in 6.0 branch and up? Thanks! |
|
My vote is 👍 ... but please only update this article and not all docs but that would create multiple hard-to-solve merge conflicts. Thanks! But first, let's wait to read the opinion of @xabbuh and @OskarStark. Thanks! |
OskarStark
reviewed
Oct 6, 2022
|
👍 for 4.4 and up. This is what we have done in most other cases and will result in the least merge difficulty. (Javier, if you want me to take care of (up-)merging this let me know) |
4490202 to
fd73939
Compare
|
Antoine, thanks for this improvement. Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, small proposition to upgrade code example here in the serializer doc using type hint on object to serialize to make example more robust from the input to output
Before continuing on this page, I want to ask if it is useful or not
Thank you!