Skip to content

Add getter and setter in the section on basic form options #16925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2022
Merged

Add getter and setter in the section on basic form options #16925

merged 1 commit into from
Jul 1, 2022

Conversation

mpdude
Copy link
Contributor

@mpdude mpdude commented Jun 28, 2022 •
edited
Loading

getter and setter were first documented in #14241, but only on the subpage on Data Mappers.

I usually check the general Form Options page when I look for a feature like this, so my suggestion is to mention it there as well.

@mpdude mpdude requested a review from xabbuh as a code owner June 28, 2022 21:39
@carsonbot carsonbot added this to the 5.4 milestone Jun 28, 2022
@mpdude
Copy link
Contributor Author

mpdude commented Jun 28, 2022

Feature was added in 5.2 – should the PR be based on that branch even if it is no longer maintained?

@mpdude mpdude force-pushed the form-data-mapper-getter-setter branch from bcefcb4 to 8d35519 Compare June 28, 2022 21:43
@xabbuh
Copy link
Member

xabbuh commented Jun 29, 2022

@mpdude 5.4 is correct as we do not backport documentation updates into unmaintained branches even if features were introduced back then

@OskarStark
Copy link
Contributor

I agree to merge this in 5.4 but adding a versionadded:: 5.2 directive could be helpful. WDYT?

@xabbuh
Copy link
Member

xabbuh commented Jul 1, 2022

Thank you Matthias.

@xabbuh xabbuh force-pushed the form-data-mapper-getter-setter branch from 1a3d4c6 to be84b5d Compare July 1, 2022 07:50
@xabbuh xabbuh merged commit cfa7597 into symfony:5.4 Jul 1, 2022
@mpdude mpdude deleted the form-data-mapper-getter-setter branch July 1, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mpdude @xabbuh @OskarStark @carsonbot