Skip to content

[PropertyInfo] Add PhpStan extractor to PropertyInfo available extractors (with promoted property) #16954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

alexandre-daubois
Copy link
Member

Resolves #16730

Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR conflicts with #16955.

Why sending two PRs to fix one issue? Maybe two commits would be more appropriate?

@alexandre-daubois
Copy link
Member Author

That's right @HeahDude, in fact I'm even wondering if it really worth having this PR pointing out pormoted properties and if the other PR is actually enough?

@alexandre-daubois
Copy link
Member Author

Kind of duplicate of #16955, I think it is not worth having this second PR just for promoted properties. Feel free to reopen if you don't agree! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants