Skip to content

[PropertyInfo] Add PhpStan extractor to PropertyInfo available extractors #16955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2022
Merged

[PropertyInfo] Add PhpStan extractor to PropertyInfo available extractors #16955

merged 1 commit into from
Jul 11, 2022

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Jul 8, 2022 •
edited
Loading

Resolves #16730

@carsonbot carsonbot added this to the 5.4 milestone Jul 8, 2022
HeahDude
HeahDude reviewed Jul 8, 2022
View reviewed changes
@alexandre-daubois alexandre-daubois mentioned this pull request Jul 8, 2022
Closed
@alexandre-daubois alexandre-daubois force-pushed the phpstan-extractor-5_4 branch 2 times, most recently from f6db230 to 0765380 Compare July 8, 2022 15:17
@javiereguiluz javiereguiluz modified the milestones: 5.4, 6.1 Jul 11, 2022
@javiereguiluz javiereguiluz changed the base branch from 5.4 to 6.1 July 11, 2022 13:27
@javiereguiluz javiereguiluz force-pushed the phpstan-extractor-5_4 branch from 0765380 to 357781b Compare July 11, 2022 13:27
@javiereguiluz javiereguiluz merged commit 7d7b528 into symfony:6.1 Jul 11, 2022
@javiereguiluz
Copy link
Member

Thanks Alexandre for this contribution and thanks Jules for the detailed review.

Please note that we merged this into 6.1 branch instead of 5.4 and we added the versionadded directive too while merging. Cheers!

@javiereguiluz javiereguiluz mentioned this pull request Jul 11, 2022
Closed
@alexandre-daubois alexandre-daubois deleted the phpstan-extractor-5_4 branch July 11, 2022 13:31
@colinodell colinodell mentioned this pull request Jun 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeahDude HeahDude HeahDude left review comments

Assignees
No one assigned
Labels
PropertyInfo Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.

[PropertyInfo] Add support for promoted properties in PhpStanExtractor
4 participants
@alexandre-daubois @javiereguiluz @HeahDude @carsonbot