[HttpFoundation] Update http_foundation.rst #16980
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this is not the case anymore ``` When PHP imports the request query, it handles request parameters like ``foo[bar]=baz`` in a special way as it creates an array. The ``get()`` method doesn't support returning arrays, so you need to use the following code:: ``` It's on line 165 in this http_foundation.rst. From what I can see, the ``get()`` method can return arrays. See image (https://ibb.co/qB0qHKc) Given this url `contacts?foo[bar]=baz` .. I can do this ``` $request->query->get('foo'); // returns ['bar' => 'baz'] ``` Tested on a symfony 4.4 application. Am I missing something?
|
Another test, and the |
|
This may target 4.4, but is deprecated in 5.1 and won't work in +6.x (ref https://github.com/symfony/symfony/blob/5.4/src/Symfony/Component/HttpFoundation/InputBag.php#L39 and symfony/symfony#34363). |
|
Thanks @kevinirlen ... but I'm afraid @HeahDude is right. We changed this recently and it no longer works as in previous versions. So, unless I'm missing something, I think we should close this without merging. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is not the case anymore because The get() method returns an array
From what I can see, the
get()method can return arrays. See image (https://ibb.co/qB0qHKc)Given this url
contacts?foo[bar]=baz.. I can do thisTested on a symfony 4.4 application.