Skip to content

[HttpKernel] Document the terminate_on_cache_hit option #16999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2022
Merged

[HttpKernel] Document the terminate_on_cache_hit option #16999

merged 1 commit into from
Oct 5, 2022

Conversation

javiereguiluz
Copy link
Member

Fixes #16919.

@javiereguiluz javiereguiluz added this to the 6.2 milestone Jul 18, 2022
@carsonbot carsonbot changed the title Document the terminate_on_cache_hit option [HttpKernel] Document the terminate_on_cache_hit option Jul 18, 2022
xabbuh
xabbuh reviewed Jul 19, 2022
View reviewed changes
@javiereguiluz
Copy link
Member Author

Thanks for your review Christian. I'm very confused, so I don't know how to move forward. Is this an internal thing that shouldn't be documented ... or is there something missing in the docs to make this option more useful? Thanks!

@OskarStark OskarStark changed the title [HttpKernel] Document the terminate_on_cache_hit option [HttpKernel] Document the terminate_on_cache_hit option Jul 22, 2022
@javiereguiluz
Copy link
Member Author

I'm closing this PR because I don't know how to move forward and it's better than others take over this. Thanks!

@wouterj
Copy link
Member

wouterj commented Sep 20, 2022 •
edited
Loading

@javiereguiluz you can reopen this PR and only revert all changes from components/http_foundation.rst. All other changes are valid once symfony/symfony#47630 is merged (and I'm certain that it will be merged before 6.2 stable).

@wouterj wouterj mentioned this pull request Sep 20, 2022
Merged
@fabpot fabpot reopened this Sep 20, 2022
fabpot added a commit to symfony/symfony that referenced this pull request Sep 20, 2022
@fabpot
feature #47630 [FrameworkBundle] Add semantic config for new terminat…
35300c4 
…e_on_cache_hit HttpCache option (wouterj)

This PR was merged into the 6.2 branch.

Discussion
----------

[FrameworkBundle] Add semantic config for new terminate_on_cache_hit HttpCache option

| Q             | A
| ------------- | ---
| Branch?       | 6.2
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | symfony/symfony-docs#16999

Adds the semantic configuration for the option introduced in Symfony 6.2 by #46763

Commits
-------

bb387e9 [FrameworkBundle] Add semantic config for new terminate_on_cache_hit HttpCache option
@javiereguiluz
Copy link
Member Author

I've reverted the wrong changes. Thanks for your review!

@OskarStark OskarStark requested review from xabbuh and wouterj October 4, 2022 16:35
@javiereguiluz javiereguiluz merged commit 45a86a3 into symfony:6.2 Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

@wouterj wouterj Awaiting requested review from wouterj

Assignees
No one assigned
Labels
HttpKernel Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.

[HttpCache] Do not call terminate() on cache hit
6 participants
@javiereguiluz @wouterj @OskarStark @xabbuh @fabpot @carsonbot