[Doctrine] show attributes instead of annotations for maker-bundle #17019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df45bd1 to
50ddde9
Compare
|
Jesse, you're on a roll! Thanks for your contributions. |
|
Uh... Is this for Symfony 5.4 docs ? Are you aware that it is supposed to still be compatible with PHP 7, AFAIU ? Changing the docs is fine for newcomers using PHP 8 and Symfony 5.4... but I'd suggest to offer the 2 alternatives instead of replacing docstring annotations completely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting w/ v1.44.0 - maker bundle only supports attribute mapping w/ entities.
Related to symfony/maker-bundle#1152