[ci] allow flex to run in CI #17020
Merged
[ci] allow flex to run in CI #17020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flex is already allowed in the application (see https://github.com/symfony-tools/code-block-checker/blob/main/composer.json#L48). That should be enough, shouldn't it? |
|
It is allowed for that package https://github.com/symfony/symfony-docs/runs/7438798967?check_suite_focus=true shows CI failing due to the plugin not explicitly being allowed. EDIT a better example w/ CI failing because of |
|
Jesse, thanks for this fix too. |
|
Good hint @jrushlow. I think we should fix it their too (see symfony-tools/symfony-application#14). |
Merged
javiereguiluz
added a commit
that referenced
this pull request
Aug 3, 2022
This PR was squashed before being merged into the 5.4 branch. Discussion ---------- Enable code blocks Revert 8f250a2 Revert fb505de from #17020 Tests were broken, see that example from #17098: ``` Run composer config --no-plugins allow-plugins.symfony/flex true Error: File "./composer.json" cannot be found in the current directory In ConfigCommand.php line 206: File "./composer.json" cannot be found in the current directory config [-g|--global] [-e|--editor] [-a|--auth] [--unset] [-l|--list] [-f|--file FILE] [--absolute] [-j|--json] [-m|--merge] [--append] [--source] [--] [<setting-key> [<setting-value>...]] Error: Process completed with exit code 1. ``` [full output](https://github.com/symfony/symfony-docs/runs/7640214086?check_suite_focus=true) It should not be necessary now that symfony-tools/symfony-application#14 has been merged. Commits ------- 7bff8b5 Enable code blocks
HeahDude
added a commit
to HeahDude/symfony-docs
that referenced
this pull request
Aug 6, 2022
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Aug 8, 2022
This PR was merged into the 4.4 branch. Discussion ---------- Fix CI by reverting symfony#17020 The CI is failing in symfony#16992 because of this, see https://github.com/symfony/symfony-docs/runs/7704382531?check_suite_focus=true. My guess if that it's now fixed upstream thanks to symfony-tools/symfony-application#14. Commits ------- 7c7c76e fix CI by reverting symfony#17020
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Aug 8, 2022
* 4.4: fix CI by reverting symfony#17020
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Aug 8, 2022
* 5.4: fix CI by reverting symfony#17020
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Aug 8, 2022
* 6.0: fix CI by reverting symfony#17020
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Aug 8, 2022
* 6.1: fix CI by reverting symfony#17020
This was referenced Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Composer 2.3.9 unless you explicitly allow/disallow a plugin (flex in our case), an error is thrown (halts our CI run) before any tests are actually ran. (Code Blocks)