[HttpFoundation] Remove misleading documentation. #1703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed some critically incorrect information.
| This method can optionally change the lifetime of the new cookie that will | ||
| be emitted by calling this method. | ||
|
|
||
| * :method:`Symfony\\Component\\HttpFoundation\\Session\\Session::invalidate`: | ||
| Clears the session data and regenerates the session id do not use ``session_destroy()``. | ||
| This is a shortcut for ``clear()`` and ``migrate()``. | ||
| Clears the all session data and regenerates session ID do not use ``session_destroy()``. |
There was a problem hiding this comment.
Clears all session data
regenerates the session ID
punktuation missing: ... session ID. Do not ...
weaverryan
added a commit
that referenced
this pull request
Sep 14, 2012
[HttpFoundation] Remove misleading documentation.
weaverryan
added a commit
that referenced
this pull request
Sep 14, 2012
|
Merged - thanks Drak! I also made the tweaks suggested by @Tobion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some critically incorrect information.